Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only notify change when kube config exists, isnt empty and complete (#190) #192

Merged
merged 1 commit into from
Jul 26, 2023
Merged

fix: only notify change when kube config exists, isnt empty and complete (#190) #192

merged 1 commit into from
Jul 26, 2023

Conversation

adietish
Copy link
Contributor

@adietish adietish commented Jul 26, 2023 •
edited
Loading

fixes #190

@adietish adietish self-assigned this Jul 26, 2023
@adietish adietish force-pushed the issue-190 branch 2 times, most recently from 1403c31 to e48c8a8 Compare July 26, 2023 11:34
@olkornii
Copy link

Tried with @adietish and it works for me.

@adietish adietish changed the title only notify change when kube config exists, isnt empty and complete (#190) fix: only notify change when kube config exists, isnt empty and complete (#190) Jul 26, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adietish adietish merged commit de3e6eb into redhat-developer:main Jul 26, 2023
@adietish adietish deleted the issue-190 branch July 26, 2023 12:07
@adietish adietish mentioned this pull request Jul 26, 2023
Closed
@adietish adietish mentioned this pull request Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olkornii olkornii olkornii approved these changes

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConfigWatcher is triggering multiple events for a single modification of a file
2 participants
@adietish @olkornii